randomize test cases where multiple socket connections are involved#24
Open
RoadRunnr wants to merge 1 commit intozeromq:masterfrom
Open
randomize test cases where multiple socket connections are involved#24RoadRunnr wants to merge 1 commit intozeromq:masterfrom
RoadRunnr wants to merge 1 commit intozeromq:masterfrom
Conversation
The test cases always processed the recv statemtn in the same order as the original outgoing message and used the same message for all clients. This had the potential to miss problems where message where returned to the wrong client. It now send a diffent message to each peer and checks that it did recieve the correct message back.
Member
|
Travis failed, shall I merge this anyhow? |
Author
|
I've used a function in the test suite that is not available on Erlang R15. The test suite update is not critical, so let's no merge it yet. I'll update the pull request tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test cases always processed the recv statemtn in the same
order as the original outgoing message and used the same
message for all clients. This had the potential to miss problems
where message where returned to the wrong client.
It now send a diffent message to each peer and checks that it did
recieve the correct message back.